search

transmission-remote-gui / transgui

🧲 A feature rich cross platform Transmission BitTorrent client. Faster and has more functionality than the built-in web GUI.
GNU General Public License v2.0
3.19k stars 274 forks source link

Several dialogs have [Escape] for yes instead of no (defaults) #1450

Open wally-crunk opened 1 year ago

wally-crunk commented 1 year ago
  1. Mac OS Ventura 13.3 (22E252)
  2. Transmission Daemon 4.0.2 (2a57b17031)
  3. Transmission GUI 5.18 https://github.com/transmission-remote-gui/transgui/commit/3fb1d339f600d9d973aa9b923b548a369bd3adbf

Several of the Warning dialog boxes in Transmission-GUI have Escape key mapped to Yes instead of No, which is definitely not the expected behavior.

For example, [Escape] causes Verification to start, but Cancel or "No" is what would be expected from the [Esc] key:

screenshot to verify

For example,[Escape] causes the Data to be deleted -- cancel or "No" is what would be expected from the [Esc] key:

Screenshot to remove

Similar but not quite the same as: (https://github.com/transmission-remote-gui/transgui/issues/1382)

pwinn commented 8 months ago

Yes, this is horrifying, and has resulted in unwanted data loss.

wally-crunk commented 7 months ago

@pwinn I believe @xavery is addressing this issue in their fork.

lighterowl commented 7 months ago

@wally-crunk I don't think this particular thing is fixed yet, though I will add an issue so I can at least track this.

pwinn commented 7 months ago

@wally-crunk I switched to that fork a few days ago, and you're right!

@xavery I tested this in v5.18.3.f build b036107, and it works as expected: Right-click, Remove torrent and data, then Esc closes the confirmation dialog and leaves the torrent in place. Whew!

lighterowl commented 7 months ago

@pwinn That's great to know! I don't remember doing anything to address this specifically so must've been something that got fixed in Lazarus in the meantime.