search

transmission / portcheck

Server component for portcheck.transmissionbt.com
MIT License
1 stars 1 forks source link

Add IPv6 support to portcheck service #3

Closed titer closed 1 year ago

titer commented 1 year ago

Fixes: #1

kelson42 commented 1 year ago

@ckerr Any chance you could review the PR @titer was kind enough to provide? If merged, I guess he could deploy it straight and that way this ~10 years old problem would be finally behind us!

ckerr commented 1 year ago

@titer next question, how does deployment work? :smile_cat:

titer commented 1 year ago

@ckerr thanks for the review! I'm adding a bit of documentation in #5 - you don't seem to have access yet but I can add your ssh key any time. This change is now deployed and the IPv6 check works fine for me

ckerr commented 1 year ago

@titer TBH the fewer tertiary things I have to know about / care about / fix when they break, the better. :slightly_smiling_face:

If it could just redeploy whenever something's merged to the repo that would be so much better than if a year from now I have to dig out my notes on how I deployed it back in March of '23

kelson42 commented 1 year ago

@ckerr We could build automatically a container image here using Github actions and then we just need to find a way to trigger the recreation of the container?! Something like https://hub.docker.com/r/containrrr/watchtower/ might be a solution. This is at least the kind of approach I would choose.

ckerr commented 1 year ago

I just want it to work; however @titer wants to do is fine with me.

...though it is nice to see Eric again thanks to this portcheck feature, so maybe it's sometimes a Good Thing for something to break once in awhile :smile_cat:

dunxd commented 1 year ago

Just spotted this. Since my router doesn't support UPNP for IPv6 I am getting an error message that the port is not open. However, it is open for IPv4 and downloads are working fine. Perhaps an orange indicator and "Port open for IPv4 only" message in this scenario would be more helpful.

If I manually open the port for IPv6 this works, but that requires firewall reconfig everytime I open Transmission.

I opened this as a separate issue when I started seeing the port showing as closed in the settings page: https://github.com/transmission/portcheck/issues/7

ckerr commented 1 year ago

Marking comment as off-topic since portcheck.transmissionbt.com is just a website service; it has no concept of Transmission's UI e.g. an indicator "port open for ipv4 only"