search

transmission / transmission

Official Transmission BitTorrent client repository
https://transmissionbt.com
Other
12.13k stars 1.21k forks source link

Tracker errors not changing Torrent status, backup trackers are not queried #2375

Open antivirtel opened 2 years ago

antivirtel commented 2 years ago

Hi,

I'm using transmission-daemon 3.00-1ubuntu1~20.04.1 from transmissionbt PPA on Ubuntu Server 20.04.3 LTS kernel 5.4.0-91-generic #102-Ubuntu SMP Fri Nov 5 16:31:28 UTC 2021 x86_64 GNU/Linux.

I have a problem with Transmission not setting torrent status to "Error" in case of having multiple trackers (eg. 1 main, 1 backup). The main tracker reports unregistered torrent, then I think:

  1. Transmission should try the other trackers too.
  2. If all trackers reporting the same error or they're unreachable, set the Torrent status to Error.

After a bit of extra testing it looks like the error status isn't set even with 1 tracker only (for already added torrents, just pause/resume). Same result when the tracker is unreachable, or if it is reachable, but reports unregistered torrent. This is quite a big of a problem I think!

The problem with not setting the status accordingly is that it's almost impossible to find the torrents having issues (think of 200+ torrents added).

Ps. These might be related, but I didn't find this issue reported in detail like this previously: #415 #412 https://github.com/equeim/tremotesf2/issues/44

Can these be fixed please?

Thank you!

ckerr commented 2 years ago

Hey @antivirtel,

I might be misunderstanding this bug report. I think what you're saying is there are two issues --

  1. We should fall back to backup trackers if the primary says 'unregistered torrent'.

This is incorrect. Backup trackers should give the same result as the primary; multiple trackers in the same tier are used to route around networking issues, e.g. an unreachable tracker. If a tracker is online and reachable and says the torrent is unregistered, that's not a networking issue and not a reason to switch to backup trackers.

  1. when a tracker is unregistered, the torrent's error status isn't set.

I'm not able to reproduce this error; in fact I can see several torrents in an error status on my local testbed right now. Maybe I'm misunderstanding the bug report and/or you have other information about how to reproduce the error your'e seeing?

antivirtel commented 2 years ago

Hi,

Thank you for the reply.

  1. Ok, that makes sense. However if I remove the backup tracker, the Error status is correctly set.
  2. I see this on a private tracker, Tier 0 tracker, 1 main, 1 backup. I can send you a file, but I can't publicly name the site or provide the file here. What's the way of sending a file privately?

Thank you!