search

transmission / transmission

Official Transmission BitTorrent client repository
https://transmissionbt.com
Other
11.67k stars 1.18k forks source link

Bumping MACOSX_DEPLOYMENT_TARGET to 11.0 #6911

Open Coeur opened 2 weeks ago

Coeur commented 2 weeks ago

Apple released Xcode 16.0 beta on June 10, 2024: https://developer.apple.com/news/releases/?id=06102024h Its new recommended minimum support is macOS 11.0.

All compatibility for macOS 10.14 and macOS 10.15 is removed in this PR.

Excepted one line: "objectVersion = 51" is kept for now, until I can install macOS 11.0 and Xcode 12.5.1 on a machine for verifying manually what is the new minimum objectVersion when developing. I can only do this in two weeks (it can be done in a separate PR).

nevack commented 2 weeks ago

Thanks, @Coeur I suggest we can merge this after 4.1.0, there's no rush, to be honest.

Overall, nicely done and good to merge, but I would suggest once again to split changes into several commits 😄. There's a bunch of thing that can be done separately:

  1. Bump Target in xcode project and cmake files.
  2. Update documentation (including website in a separate PR, to be merged with 4.something release)
  3. Remove compatibility shims.
  4. Remove compatibility branching.
  5. Remove no longer used resources.
Coeur commented 2 weeks ago

I suggest we can merge this after 4.1.0, there's no rush, to be honest.

What are the odds that Transmission 4.1.0 FINAL lands before the 10th of September 2024? To me, reflecting on the release history of Transmission, 4.1.0 will only land in December 2024 at the earliest in my opinion.

And all the subsequent 4.1.x (for a year or two) would need to be maintained for a system that Xcode doesn't really support anymore. So I do not want to have untestable support for macOS 10.14 and 10.15 in Transmission 4.1.x.