Naming issue with Ed25519 and Curve25519

[gjgd]

https://github.com/transmute-industries/did-key.js/tree/713cbd19a034f221e0ee937d1fb86d2323961dd1/packages/ed25519/src

• Curve25519 is the name of the curve (same as Secp256K1) so keys should be named "Curve25519Keypair", not "Ed25519KeyPair"
• Ed25519 is the name of the signing algorithm (same as ES256K) so the signing algorithm should be named "Ed25519", not "EdDSA"

[OR13]

The convention for these is loosely modeled off of:

• https://github.com/digitalbazaar/secp256k1-key-pair
• https://github.com/digitalbazaar/crypto-ld/blob/master/lib/Ed25519KeyPair.js

The modules might be better named JWS not ES256K and EdDSA... since secp256k1 both support Schnorr and ECDSA....

The term "Curve25519KeyPair" is probably not a good choice for normal "Ed25519KeyPair", given this:

https://w3c-ccg.github.io/did-method-key/#key-derivation-lacks-proof

and in fact we also have a key class that just does ECDH... https://github.com/transmute-industries/did-key.js/blob/master/packages/x25519/src/X25519KeyPair.ts#L222

^ which you would probably have a similar naming objection too, since X25519 is for key agreement, not for curve naming.

In general, we (and digital bazaar) appear to be following the lib sodium conventions here... https://libsodium.gitbook.io/doc/advanced/ed25519-curve25519

But I am open to exploring improvemnets.