transmute-industries / vc.transmute.world

Transmute's VC-HTTP-API
https://test.did.ai
Apache License 2.0
4 stars 1 forks source link

Implementation of CCG methods does not adhere to spec #13

Open mkhraisha opened 4 years ago

mkhraisha commented 4 years ago

The methods outlined in the CCG verifier take in an object of the format: "verifiableCredential": {} currently the swagger on this repo is outlined correctly however the implementation expects a "credentials": {} object and breaks when a "verifiableCredential": {}" object is provided.

OR13 commented 4 years ago

@mkhraisha did you mean to open this issue here: https://transmute-industries.github.io/vc-http-api/#/Verifier/verifyPresentation ?

OR13 commented 4 years ago

this repo contains endpoints that are CCG conformant and ones that are not. they are labels as such...

the interop test suite is against the ccg endpoints, but our demos use the other ones, when they are equivalent.... or when we require functionality not defined in ccg.

OR13 commented 4 years ago

Note that https://w3c-ccg.github.io/vc-issuer-http-api/index.html#/internal/issueCredential

does use "credential"

and that https://vc.transmute.world/api/docs/static/index.html#/VC%20Data%20Model/post_vc_data_model_credentials

conforms...

note that: https://w3c-ccg.github.io/vc-verifier-http-api/index.html#/internal/verifyCredential

uses "verifiableCredential"

and that https://vc.transmute.world/api/docs/static/index.html#/CCG%20Verifier/post_verifier_credentials

conforms