Closed phbnf closed 3 months ago
Attention: Patch coverage is 33.77246%
with 553 lines
in your changes missing coverage. Please review.
Project coverage is 28.64%. Comparing base (
46ec9c2
) to head (047e797
). Report is 30 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Just before I dive in... :)
The stuff under personalities/ct_static_api
is, I think, intended to move to another repo (e.g. ct-go?) in the near term, and it's just here in this PR as a means to iterate quickly given that Tessera APIs etc. are still a little in flux. Is that right?
Just before I dive in... :)
The stuff under
personalities/ct_static_api
is, I think, intended to move to another repo (e.g. ct-go?) in the near term, and it's just here in this PR as a means to iterate quickly given that Tessera APIs etc. are still a little in flux. Is that right?
Yes, see #88, I added a list of tasks there, including one to move it to its own repo.
88
This PR has two commits to ease review:
If this (big?!) PR is too hard to review, I could send self contained chunks corresponding to the list above. I wish I had done this in the first (or previous to first!) place... but I had to do it first to know exactly how to break it down.
There's probably more things I could have put in this PR, like copying more things over to avoid puling in more dependencies for instance. I've made a list of follow up AIs in #88.