search

transparencyint / CGIP

Climate Governance Integrity Program
6 stars 1 forks source link

Loading indicator for Actor Groups and Connections #265

Closed janmonschke closed 11 years ago

janmonschke commented 11 years ago

Currently the loading indicator only works for actors. It would be great to have it also for actor groups and connections. With the introduction of recent changes the actor groups have no more indicator at all.

futchas commented 11 years ago

I put the same CSS code in the actor-group for the loader, but it doesn't show the loader image and i don't know why. See commit 128692983ad68144e4f35359ad60d94034ce72c3

mrflix commented 11 years ago

Let me look into it. Please stop copy & pasta. We are sharing styles here – the group has the class .actor-holder which applies the actor styles (see first line actor.styl). So the style should already be there. It's probably a overlapping problem, or something gets overwritten.

On Mar 2, 2013, at 1:11 PM, "Iyad A." notifications@github.com wrote:

I put the same CSS code in the actor-group for the loader, but it doesn't show the loader image and i don't know why. See commit 1286929

— Reply to this email directly or view it on GitHub.

mrflix commented 11 years ago

fixed – it was the z-index, because there are several 'actors' stacked on top of each other. I also added the corruption risk indicator to the group.

futchas commented 11 years ago

Ok understood! Thanks! The connection has opacity and the not-allowed cursor to indicate the lock status. I also agree to @mrflix adivice to not show the loader in the connection for now. It's difficult to find a got position for it

janmonschke commented 11 years ago

Seems like the z-index thingy makes it now impossible to drag actors out of their group. @mrflix can you check that?