search

transparentdemocracy / voting-data

Voting behavior data extracted from plenary reports of the Belgian federal government.
5 stars 1 forks source link

Add fraction information in JSON #26

Closed sandervh14 closed 1 month ago

sandervh14 commented 1 month ago

This is important info, used in the mockups.

Karel wrote enrichment to download politicians ("actors") and their party affiliations. Add this party information in the votes.json. Or: would be better to reduce the votes.json size: adding a politicians.json and linking in every vote from votes.json to politicians.json with a politician_id.

karel1980 commented 1 month ago

I've changed votes.json so it only contains the politician ids. This brings the file size down by about 50%.

I've also changed vote extraction so we don't discard all votes when we can't parse the vote results exactly. Doing this gives us results that are closer to reality.

karel1980 commented 1 month ago

@sandervh14 please review and close if you're okay with this.

karel1980 commented 1 month ago

Also committed the politicians json which contains id, full name and party (generated using td-politicians-json)

sandervh14 commented 1 month ago

Great work! You were on a roll!! 😄

There were only 2 minor things I noticed for improvement, and they are only improvements for the longer term: #30 and #31.