transparentdemocracy / website

The frontend that visualizes the information obtained from the backend. Written in Angular.
1 stars 0 forks source link

Issues found in test #20

Open idotj opened 1 month ago

idotj commented 1 month ago

After several fixes and reworks, here is the list of points left from the original issue #17

[ ] Motions without a document reference: show a message similar to the one warning about AI translations, now with the warning "We could not find the document reference for this vote." (translated in Dutch and French)

[ ] When clicking on the right of a motion (below "Aangenomen" or "Verworpen"), the motion should open/close, like when clicking on the title of the motion.

[ ] The search has become somewhat slower. I don't think we'll get it much faster, we just made it search in more columns of the data. Can you introduce a spinner while search is waiting for the results?

[x] Remove the display of the long text below the document references of a motion. (For example, the text "Ik meen dat de vivaldiregering........" below the first motion made on 08-05-2024) This text is just not high-quality enough, the document summaries are more sensical to understand

[ ] On smartphone layout, can the plenary title take the full width of the blue box of the data of a plenary, and the number of motions and the data be below the plenary title? (number of motions left, date right? So that when scrolling we still see a "timeline")

[ ] Can the same be done as above, for motion groups on the motion page? Because now the number of motions and the date on the right take up half the screen width, the title of the motion group is divided over many lines.

[ ] Adapt IDs in titles of plenaries from "Plenaire vergadering 55_309" to just "Plenaire vergadering 309".

sandervh14 commented 1 month ago

Adding one:

[x] Add mailbox watdoetdepolitiek@gmail.com as alternative way of raising issues or suggestions for improvement, on the help page.

sandervh14 commented 1 month ago

Fixed:

[x] Remove the display of the long text below the document references of a motion. (For example, the text "Ik meen dat de vivaldiregering........" below the first motion made on 08-05-2024) This text is just not high-quality enough, the document summaries are more sensical to understand [x] Add mailbox watdoetdepolitiek@gmail.com as alternative way of raising issues or suggestions for improvement, on the help page.

sandervh14 commented 1 month ago

Adding two new:

image

[ ] Don't overrun the motion group content with the "Aangenomen" right side-bar. This occurs when expanding a motion group that contains only one motion. [ ] Display the percentages of party votes related to the total of votes, not related to the total of votes within the "Yes", "No" or "Abstention" columns separately. [ ] Would be nice to have the totals on top also in %, next to the absolute number of "Yes", "No" and "Abstention" votes.

GuidoDechamps commented 1 month ago

_[ ] Display the percentages of party votes related to the total of votes, not related to the total of votes within the "Yes", "No" or "Abstention" columns separately.

=> debatable. When in the column of yes votes seems logical that percentage relates to yes votes. Are we sure we want it like that ? I have no preference but seems like subjective view. perhaps we need to support both?

[ ] Would be nice to have the totals on top also in %, next to the absolute number of "Yes", "No" and "Abstention" votes. Agreed