Implement Create, Edit, and Delete Functionality for Datasets

[Uchechukwu-Onye-Igbo]

As a data contributor to the TDC Portal, I want to be able to add new datasets, edit my existing datasets, and delete my datasets when necessary, so that I can manage the my data resources available on the platform effectively.

Tasklist (TBD - to be added by the developer)

• [add task]

‼️ Important Note

Ensure the implementation of this ticket covers observations listed here https://github.com/transport-data/tdc-data-portal/issues/35#issuecomment-2348482545

Acceptance Criteria

Given that I have access to the data portal frontend,

• [x] i am able to add a new dataset using a creation process that captures all necessary details about the data.
• [x] i am able to edit the details of my existing dataset, and changes are reflected on the platform.
• [x] i can delete a dataset, and it is removed from the platform after confirmation.
• [x] i will receive a confirmation dialog before deleting any dataset.
• [x] i will feedback messages to confirm the successful creation, editing, or deletion of datasets.

[luccasmmg]

https://github.com/transport-data/tdc-data-portal/tree/main/docs/datasets

[Uchechukwu-Onye-Igbo]

QA Feedback

Bugs & Improvements:

• No values are showing in the dropdown for the "Define Unit" input.
• The "Geographies" and "Language" filters need further work. Typing the name of something in the list does not show up the result.
• Check all other dropdowns where users can type input to ensure they are functioning correctly.
• The "Dimensioning" field is currently required but sectors are not, but it only accepts text, makes me wonder if it should be.
• There should be an explanation for fields like "Dimensioning" to provide better clarity to users. Maybe a text under the fields to explain them to the users.
• For datasets listed under "My Datasets," users should be able to edit them by clicking on the edit button next to it. Inform William that the "Edit" button next to the page should link to the edit screen and include a pencil icon next to the edit text for clarity or just have only the pencil icon there.
• When a dataset is created and set to private, it still displays a public tag after creation in the my dataset screen. Private datasets should not have public tags on them. This is a bug that needs fixing.

@luccasmmg

[luccasmmg]

No values are showing in the dropdown for the "Define Unit" input.

As explained this is the intended use case, the input is there not to search but to allow the user to add multiple itens

The "Geographies" and "Language" filters need further work. Typing the name of something in the list does not show up the result. Check all other dropdowns where users can type input to ensure they are functioning correctly.

Done

The "Dimensioning" field is currently required but sectors are not, but it only accepts text, makes me wonder if it should be.

Removed required after talking with Demenech

There should be an explanation for fields like "Dimensioning" to provide better clarity to users. Maybe a text under the fields to explain them to the users.

This needs to be provided by the client as currently we dont have a good definition like data_provider or url (Already checked with Demenech to confirm)

For datasets listed under "My Datasets," users should be able to edit them by clicking on the edit button next to it. Inform William that the "Edit" button next to the page should link to the edit screen and include a pencil icon next to the edit text for clarity or just have only the pencil icon there.

Done

When a dataset is created and set to private, it still displays a public tag after creation in the my dataset screen. Private datasets should not have public tags on them. This is a bug that needs fixing.

Done

[Uchechukwu-Onye-Igbo]

QA Feedback

Hello @luccasmmg, kindly fix this

• when creating dataset, when i get to the last step and click submit, i get an error that reads: Validation error: "id": The input field id was not expected.
• users are currently not able to edit or delete public datasets, but they can see the edit button and delete buttons. this should not be possible for user who does not belong to the dataset's organsation and does not have edit access.
• clicking on a dataset showing up in the my organsation tab so i can view it, i get a 404 error

[luccasmmg]

1. Cant reproduce it pls send video
2. Please give examples, my assumptions is that all datasets in My Datasets should be editable, and that the cases on My Organization should be handled by @willy1989cv since i didnt write that code
3. Thats a bug on the My Organization tab, its showing draft datasets when it shouldnt

Note that the only point on my end of the work is point 1, everything else you pointed out is in the My organization and My dataset tab

[Uchechukwu-Onye-Igbo]

1. Cant reproduce it pls send video
2. Please give examples, my assumptions is that all datasets in My Datasets should be editable, and that the cases on My Organization should be handled by @willy1989cv since i didnt write that code
3. Thats a bug on the My Organization tab, its showing draft datasets when it shouldnt

Note that the only point on my end of the work is point 1, everything else you pointed out is in the My organization and My dataset tab

hi @luccasmmg, i have sent you the video. thanks for clarifying the other points, I have directed it to the right person

[luccasmmg]

Can you please try again?

[Uchechukwu-Onye-Igbo]

Can you please try again?

thanks @luccasmmg it now works