search

transportapi / api-console

A Web Component for an interactive REST console based on RAML files
Other
0 stars 0 forks source link

Merge from upstream #12

Closed harry-wood closed 7 years ago

harry-wood commented 7 years ago

For testing this, here's the grunt dist: http://1.placr.co.uk/sandbox/harry/api-console/merge-upstream/

harry-wood commented 7 years ago

Minor problem with the merge: One of meddle's changes was to make it default to showing the schema. We seem to have lost that with the merge.

Major problem with the new upstream code: The latest api-console no longer supports anchor links. Previous behaviour was to support anchor links jumping to a section of the docs, and to automatically set these in the browser URL dynamically as you unfold sections of the docs.

Our current master code supports this http://1.placr.co.uk/sandbox/harry/api-console/master/?raml=https://transportapi.com/v3/raml/transportapi.raml##uk_train_station_station_code_live_json

new code doesn't: http://1.placr.co.uk/sandbox/harry/api-console/upstream/?raml=https://transportapi.com/v3/raml/transportapi.raml##uk_train_station_station_code_live_json

On investigation I have discovered that this was working up until a commit they did shortly after we forked mid-2015, which sort of looks like they broke this functionality by accident. So thats going to be a problem for us. I'm going to try to raise this here: https://github.com/mulesoft/api-console/issues/60#issuecomment-272907076