search

transportenergy / database

Tools for accessing and maintaining the iTEM model & historical databases
https://transportenergy.rtfd.io
GNU General Public License v3.0
24 stars 8 forks source link

Correct order-of-magnitude error in raw data for T001 #40

Closed khaeru closed 3 years ago

khaeru commented 3 years ago

Closes #32.

codecov[bot] commented 3 years ago

Codecov Report

Merging #40 (32349be) into master (b73022e) will increase coverage by 0.43%. The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   52.09%   52.53%   +0.43%     
==========================================
  Files          35       35              
  Lines        1503     1521      +18     
==========================================
+ Hits          783      799      +16     
- Misses        720      722       +2
Impacted Files Coverage Δ
item/historical/__init__.py 89.77% <40.00%> (-1.90%) :arrow_down:
item/historical/scripts/T000.py 100.00% <100.00%> (ø)
item/historical/scripts/T001.py 100.00% <100.00%> (ø)
item/historical/util.py 96.55% <100.00%> (+1.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b73022e...2c4fff7. Read the comment docs.

soniayeh commented 3 years ago

The fix was to multiply 100 to data 1985-2001. But I think the fix should be dividing 100 to data 2002 and after. Can you double check?