Closed khaeru closed 3 years ago
The notebook for T005 contained the following text:
There are five IPCC descriptions and this is how each one is mapped to our schema:
For countries: IPCC --> Mode Railways --> Rail Road Transportation --> Road Civil Aviation --> Air Other Transportation --> Other Water-borne Navigation --> Shipping
For Int. Aviation country: IPCC --> Mode Civil Aviation --> Domestic Aviation
For Int. Shipping country: IPCC --> Mode Water-Borne Navigation --> Domestic Shipping
This seems wrong. "International Aviation" is not "Domestic Aviation"; these things are the opposite of one another. The mode in this case should be "Air".
The PR corrects this error.
Merging #71 (3e9134f) into master (ac4802d) will increase coverage by
15.68%
. The diff coverage is93.80%
.
@@ Coverage Diff @@
## master #71 +/- ##
===========================================
+ Coverage 57.23% 72.91% +15.68%
===========================================
Files 49 32 -17
Lines 1887 1370 -517
===========================================
- Hits 1080 999 -81
+ Misses 807 371 -436
Impacted Files | Coverage Δ | |
---|---|---|
item/structure/__init__.py | 100.00% <ø> (ø) |
|
item/structure/sdmx.py | 92.64% <ø> (ø) |
|
item/historical/T001.py | 79.31% <66.66%> (ø) |
|
item/historical/__init__.py | 89.40% <91.35%> (-5.65%) |
:arrow_down: |
item/historical/T009.py | 92.85% <92.85%> (ø) |
|
item/historical/T000.py | 100.00% <100.00%> (ø) |
|
item/historical/T002.py | 100.00% <100.00%> (ø) |
|
item/historical/T003.py | 100.00% <100.00%> (ø) |
|
item/historical/T004.py | 100.00% <100.00%> (ø) |
|
item/historical/T005.py | 100.00% <100.00%> (ø) |
|
... and 33 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ac4802d...3e9134f. Read the comment docs.
Supersedes #22; will close #49.
.historical.process()
.