search

transportenergy / database

Tools for accessing and maintaining the iTEM model & historical databases
https://transportenergy.rtfd.io
GNU General Public License v3.0
24 stars 8 forks source link

Make ColumnName match sdmx nomenclature #72

Closed francescolovat closed 3 years ago

francescolovat commented 3 years ago

This PR closes #69.

To solve the issue, I've edited the attributes of class ColumnName to match the nomenclature returned when running sdmx.generate() with IDs ("VEHICLE" and "MODE").

How to review:

codecov[bot] commented 3 years ago

Codecov Report

Merging #72 (7b66813) into master (ac4802d) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   57.23%   57.23%           
=======================================
  Files          49       49           
  Lines        1887     1887           
=======================================
  Hits         1080     1080           
  Misses        807      807
Impacted Files Coverage Δ
item/historical/scripts/T000.py 100.00% <ø> (ø)
item/historical/scripts/T003.py 100.00% <ø> (ø)
item/historical/diagnostic/A003.py 100.00% <100.00%> (ø)
item/historical/scripts/T009.py 93.75% <100.00%> (ø)
item/historical/scripts/util/managers/dataframe.py 96.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac4802d...7b66813. Read the comment docs.

francescolovat commented 3 years ago

@khaeru, tests are failing because my account does not have the right permissions for Google Cloud Storage. I hope we can find a solution for this.

From the test run: Failed to create file system for "gcs:data.transportenergy.org/historical/ci/45/": failed configuring Google Cloud Storage Service Account: error processing credentials: unexpected end of JSON input

khaeru commented 3 years ago

As mentioned in Slack, sorry for the miscommunication here! The approach (using the SDMX dimension names, e.g. "MODE", wherever possible) is definitely correct, but this was addressed simultaneously in #71 along with more drastic changes, e.g. completely removing the outdated ColumnName enum.