Open HannaMorde opened 8 months ago
Hi @Hannamm —thank you very much for your contributions to the iTEM Open Data code! We appreciate that members of the community, such as yourself, make efforts to expand the scope and quality of the data included in this shared resource.
In this review, I will do a few things:
To be clear, I understand from you and @soniayeh that the course in which you did this work is coming to an end, so you may not have dedicated time to do (2) or (3). So those TODOs are mentioned without saying who will do them or when—it could be you, me, or someone else; sooner or later.
item.historical.{T015,T016,T017}
.class AtoWorkbook
in a single file, then import it in each of the 3 modules, setting some different parameters or creating a subclass.T000
do not execute any code when they are imported; they instead provide a function like process()
that triggers processing of the data.main
branch of transportenergy/metadata.transportenergy:main
.transport_data.adb
code maintained by the Transport Data Commons, here; make use of the TDC code where possible, and keep the features specific to iTEM Open Data.class ItemTransformer
added in #80; merge common actions to common code.item.tests.test_historical
contains tests of the existing (T000–T010, T012) data modules, and these tests should be expanded to test the modules added in this PR.
Data cleaning of "ATO Workbook (TRANSPORT ACTIVITY & SERVICES (TAS))2023.xlsx" was done and merged the output into the cleaned "master dataset.csv".