search

tranvutuan2001 / ORpraktikum

4 stars 3 forks source link

Task e #28

Closed z-008 closed 2 years ago

z-008 commented 2 years ago

As per @PatrickSchro, I grouped data only for year 2001, 2009 and 2015 and rest of the data is passed as it is .

z-008 commented 2 years ago

This branch is created on top of Tuan's changes (his branch)

z-008 commented 2 years ago

@tranvutuan2001 thanks will do all of this and update

z-008 commented 2 years ago

But I guess these changes are halted for now so please dont merge it

lakhoune commented 2 years ago

@z-008 there are also merge conflicts that need to be resolved

z-008 commented 2 years ago

@lakhoune yeah conflicts because a lot of new code has been pushed and this PR is quite old now. For now I don't think we are moving ahead with these changes as @kevin code doesn't include consolidation

PatrickSchro commented 2 years ago

Please notice that kevin changed a lot in the way the files are imported, so do not merge this version at this point. We also added the max_heat_demand in the csv file in W/m2 (row 118) in dataprp.py . We are not sure if thats the best way yet but I think its better that comapring the heatpumps with the maxheatdemand in kWh divided by 3600 (whats that value?). Please zoom with me if you have questions about that.

lakhoune commented 2 years ago

Can this be closed?

z-008 commented 2 years ago

Let it be @lakhoune we can close it later if we don't require it