Downloaded count went over total left

tranxuanthang / lrcget

Utility for mass-downloading LRC synced lyrics for your offline music library.

MIT License

734 stars 23 forks source link

Downloaded count went over total left #131

Open fineless71 opened 1 week ago

fineless71 commented 1 week ago

~I can't reproduce this but I'd figure I'd file a bug report:~ This happened to me again, but with a different song. Same symptoms, one of the duplicates is the very last one. Seems to happen ~50% of the time, maybe related to reloading but I'm not decently sure of the cause.

I pressed the "Download All Lyrics" button and it went past the max. (17/16)

Sorry for the censor: In the list, one of the songs is listed twice, one of them is at the end, and one is near the middle.

fineless71 commented 1 week ago

I used the "Download Album Lyrics" and I got this happen, the bottom song is not in the album. This was shortly after I cancelling a download for all songs. Sorry for the censor before as it included songs I didn't want to share.

fineless71 commented 16 hours ago

This is 100% an assumption and I have no idea how the code works, but my guess is that when stopping a mass download, it doesn't cancel the active web requests, so when you start a new download and then a request from the previous download finishes, it gets added to the current one

Edit: Nevermind, I tried with a long wait between downloads and this bug still happened.