search

tranxuanthang / lrcget

Utility for mass-downloading LRC synced lyrics for your offline music library.
MIT License
834 stars 26 forks source link

Lyrics aren't fetched on the first try #138

Open vlnka opened 1 month ago

vlnka commented 1 month ago

I have a library of about 50k tracks I ran LRCGET on. It found lyrics for most of them which is great.

But when I ran it in the same folder again, lyrics for more tracks were found. I did that several times back-to-back and it always found lyrics for a few more tracks.

Any idea what causes this? Why can't lyrics for all tracks be fetched successfully in one run?

tranxuanthang commented 1 month ago

It is expected, you can see my answer in this issue for more explanation: https://github.com/tranxuanthang/lrcget/issues/132#issuecomment-2380089880

vlnka commented 1 month ago

I somewhat refuse to believe lyrics for ~30% (about 4k) of my previous undetected songs popped up within 2 hours of the initial fetch

fineless71 commented 1 month ago

It always redownloads lyrics if a track has only plain and not synced lyrics, maybe that is what is happening? I think it would be more clear if it said something like "Plain lyrics already downloaded" for those tracks

It also seems to always redownload even synced lyrics if you download for a specific album

vlnka commented 1 month ago

oh does it? weird

not sure how related it is but this also keep happenings when i'm running a scan on a library where some songs already have their lyrics - multiple lines for the same track image

tranxuanthang commented 1 month ago

@vlnka

not sure how related it is but this also keep happenings when i'm running a scan on a library where some songs already have their lyrics - multiple lines for the same track

It looks like it's a new bug unrelated to your original post, I'll check this out later today.

I somewhat refuse to believe lyrics for ~30% (about 4k) of my previous undetected songs popped up within 2 hours of the initial fetch

It is actually true, you might get a few more lyrics if you rerun after a couple of days (2 hours is sometimes too short).

It always redownloads lyrics if a track has only plain and not synced lyrics, maybe that is what is happening? I think it would be more clear if it said something like "Plain lyrics already downloaded" for those tracks

It also seems to always redownload even synced lyrics if you download for a specific album

@fineless71 I think it is not related to OP's issue. You can read more in https://github.com/tranxuanthang/lrcget/issues/30

Zedniac commented 1 month ago

Regarding the issue where multiple lines show up for the same track, I've noticed that as well. Often happens if I scroll in the list while it's scanning. Happy to provide more info or try to recreate the issue if needed