search

tranxuanthang / lrcget

Utility for mass-downloading LRC synced lyrics for your offline music library.
MIT License
540 stars 20 forks source link

macOS Version GUI Bugs #25

Closed SawkeeReemo closed 3 months ago

SawkeeReemo commented 8 months ago

First of all, thank you! This is a great little app, impressive work so far! I just wanted to drop by and give you a few notes on some macOS issues I've found that you hopefully find helpful as you work:

  1. Can't scroll on any page. So I can never see anything past what gets loaded on the screen at the beginning.
  2. No stop button for music player, have to quit the app.

Other than that, I think it works really well. Would love to know where you are pulling these from, and if it's possible to add more sources. Thanks!

tranxuanthang commented 7 months ago

I would gladly accept a PR from anyone who are interested in fixing this issue, because I do not own a mac device and neither do people around me.

tueksta commented 7 months ago

I'm on OSX Ventura 13.6.1 and can't confirm this. Scrolling works fine everywhere, except in the lyrics window where it's not supposed to work, as autoscrolling along with the music is enforced.

And the play button turns into a pause button on playing, so not stop button needed.

edit: actually just saw, when there is too many search results, the results aren't scrollable. ah, and when the lyrics player is open, the song scroller is behind the lyrics, instead of resizing to the new boundaries.

tranxuanthang commented 4 months ago

@SawkeeReemo @tueksta Could you verify all the issues on macOS after the latest update? The scroll bar is now webview native, so there should be no strange problems. Search result is now also scrollable properly.

https://github.com/tranxuanthang/lrcget/releases/tag/0.3.0

tranxuanthang commented 3 months ago

Closing this issue to clean up. If you are still facing any problems, feel free to reopen this or open a new one!