Display [Instrumental] label on songs that are verified instrumental

tranxuanthang / lrcget

Utility for mass-downloading LRC synced lyrics for your offline music library.

MIT License

540 stars 20 forks source link

Display [Instrumental] label on songs that are verified instrumental #36

Closed shipurjan closed 1 month ago

shipurjan commented 5 months ago

Right now it only says [Synced] or [Plain]

tranxuanthang commented 5 months ago

I think we need to save a file to persist the instrumental status even after rescanning of directories. Two possible options are:

We save a .lrc file with the content contains only a custom invented tag name like [ins:true], marking the track that has the same name as instrumental
Or simply save an empty .txt file with the same name

lightmaster commented 5 months ago

Could also save a .lrc with (Instrumental) in it. That way if you're looking through your collection on whatever media player you use, you won't see it is missing lyrics. There are plenty of songs with titles that wouldn't immediately hint that it's probably instrumental.

Dr-Blank commented 5 months ago

as of now there is no metadata tag for marking the track to be instrumental in .lrc format afaik.

Since instrumental tracks have no lyrics, empty lyrics file makes logical sense. but it also needs to be discernable that the lyrics are empty on purpose and not empty because of a bug. hence some sort of metadata tag should be used to indicate that the file is empty on purpose.

I suggest using the existing author tag "au" for this instead of creating a new one.

e.g. metadata would be

[ar: Jefferson Airplane]
[al: Surrealistic Pillow]
[au: instrumental]
[length: 2:58]

tranxuanthang commented 5 months ago

@Dr-Blank It makes sense, I prefer not inventing new standards, and unconventional tag names might potentially break some faulty clients.

I agree with the solution of adding an LRC file that contains [au: instrumental], although I don't think adding other metadata tags (ar, al, au, ...) is necessary.

If someone could make a PR for this, it would be greatly appreciated!

tranxuanthang commented 1 month ago

Good news: it is kind of working after commit https://github.com/tranxuanthang/lrcget/commit/754dd0f514ced70318e5982e7474d5fefae0321c, though I suspect some more work needs to be done in order to release this.

tranxuanthang commented 1 month ago

Resolved in v0.3.1 🚀

https://github.com/tranxuanthang/lrcget/releases/tag/0.3.1