tranxuanthang / lrcget

Utility for mass-downloading LRC synced lyrics for your offline music library.
MIT License
535 stars 20 forks source link

NowPlaying Improvements: seek buttons, play/pause track item syncing, replay button, shortcuts. #76

Closed esmersmith closed 1 month ago

esmersmith commented 1 month ago

Here are the list of changes:

I think I would like to implement next/previous buttons as well, but that requires managing the track list state across different tabs, so I'll probably add that in a different PR. Let me know if you want anything changed.

tranxuanthang commented 1 month ago

I've just tested this on my machine and it works great!

Really love the replay feature, I admit I'm a bit annoyed that I can't replay the song in the current released version. Another small thing I'd love to have on the now playing is that, after the song is ended, we can click on any point on the seek bar to replay it at the selected point. If you want to help with that then it would be amazing (another PR is fine)!

One more useful feature is in-app volume control (as suggested in https://github.com/tranxuanthang/lrcget/issues/38). This might require some additional commands from the Rust side. But asking more from you is probably too much, so feel free to continue with whatever you have planned or enjoy working on!

Anyway, this is a solid PR. Thank you for your hard work!