tranxuanthang / lrcget

Utility for mass-downloading LRC synced lyrics for your offline music library.
MIT License
728 stars 21 forks source link

"Download All Lyrics" doesn't work for tracks, only for albums #81

Closed tangsgod closed 4 months ago

tangsgod commented 4 months ago

You can see in this video that the "Download All Lyrics" doesn't work when on Tracks section, but does in Albums section.

The folder here is about 120 000 tracks

https://youtu.be/FGNivVkh7ZY?si=Y4cJQSC5IsGBNLdt

tranxuanthang commented 4 months ago

@tangsgod I'm looking into it, but it doesn't seem to be related to a performance issue.

Could you help me check the console log to see if there is anything wrong?

  1. Click the spider button
  2. In the developer tool, choose tab Console
  3. Try clicking "Download all lyrics" button
  4. See if there is anything strange or error log shown in console
  5. Send me the screenshot or text of the error if any

image

tangsgod commented 4 months ago

Thank you for your help

Here is the screenshot of the console after hitting the Download button for 90 000 songs

Le mer. 22 mai 2024 à 17:51, tranxuanthang @.***> a écrit :

@tangsgod https://github.com/tangsgod I'm looking into it, but it doesn't seem to be related to a performance issue.

Could you help me check the console log to see if there is anything wrong?

  1. Click the spider button
  2. In the developer tool, choose tab Console
  3. Try clicking "Download all lyrics" button
  4. See if there is anything strange or error log shown in console
  5. Send me the screenshot or text of the error if any

image.png (view on web) https://github.com/tranxuanthang/lrcget/assets/15942946/98db39a5-1a54-4147-ac42-5ff3005921a2

— Reply to this email directly, view it on GitHub https://github.com/tranxuanthang/lrcget/issues/81#issuecomment-2125136339, or unsubscribe https://github.com/notifications/unsubscribe-auth/AULQLFMATSUFZHXA6Y457R3ZDS5J5AVCNFSM6AAAAABICIMHQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRVGEZTMMZTHE . You are receiving this because you were mentioned.Message ID: @.***>

tranxuanthang commented 4 months ago

@tangsgod I'm not seeing any image uploaded, could you reupload it?

tangsgod commented 4 months ago

Of course, here it is

Le ven. 24 mai 2024 à 11:13, tranxuanthang @.***> a écrit :

@tangsgod https://github.com/tangsgod I'm not seeing any image uploaded, could you reupload it?

— Reply to this email directly, view it on GitHub https://github.com/tranxuanthang/lrcget/issues/81#issuecomment-2129033216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AULQLFIUD7AHNUHIMXBACI3ZD4AC7AVCNFSM6AAAAABICIMHQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRZGAZTGMRRGY . You are receiving this because you were mentioned.Message ID: @.***>

tangsgod commented 4 months ago

The image is in the mail

Le ven. 24 mai 2024 à 12:23, Gaëtan Yorfeddog @.***> a écrit :

Of course, here it is

Le ven. 24 mai 2024 à 11:13, tranxuanthang @.***> a écrit :

@tangsgod https://github.com/tangsgod I'm not seeing any image uploaded, could you reupload it?

— Reply to this email directly, view it on GitHub https://github.com/tranxuanthang/lrcget/issues/81#issuecomment-2129033216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AULQLFIUD7AHNUHIMXBACI3ZD4AC7AVCNFSM6AAAAABICIMHQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRZGAZTGMRRGY . You are receiving this because you were mentioned.Message ID: @.***>

tranxuanthang commented 4 months ago

@tangsgod Maybe GitHub doesn't reupload your attachment to GitHub issue, and I also cannot see it in my inbox. If you prefer emails, could you send it directly to my email address?

My email: hoangtudevops@protonmail.com

tranxuanthang commented 4 months ago

It is probably resolved in commit https://github.com/tranxuanthang/lrcget/commit/0ec12966a521a40801a795c70e241be514b4dd22, released in v0.3.2. If you have any problems, feel free to leave a comment and I will reopen this, thank you!