search

tranxuanthang / lrcget

Utility for mass-downloading LRC synced lyrics for your offline music library.
MIT License
883 stars 28 forks source link

Albums and Songs not showing up in LRCGET #92

Open tarekme28 opened 5 months ago

tarekme28 commented 5 months ago

i've noticed there are albums and songs that don't show up in the Tracks/Albums/Artists tap when i load the parent directory but they neither show up when i load exactly the one 2024-06-06_21-35 2024-06-06_21-35_1

bkev said it's because some .mp3's have to many tags? i was able to find differences in the tags, but not yet include those that are supposedly responsible for the failure. does someone know how to fix this? there's been a lot of albums that don't get included so i'm not even able to search for .lrc's. for those i have to use mxlrc

ginjaninja1 commented 5 months ago

image https://docs.mp3tag.de/mapping/#involvedpeople presence of INVOLVEDPEOPLE tag as appreciated by mp3tag stops ingestion into LRCGET; tested on 0.3.2 with ID3v2.3 UTF16

although consistency in tag usage/expectations is fraught, I would have thought LRCGET could ignore this tag as its functionality [for pop music] would be driven by what might be colloquially understood as Artist(s)/AlbumArtist(s)/[track]Title/AlbumName

zAgny commented 5 months ago

I just figured this out. When a file contains multiple genres, for example: Rock\Metal, LRCGET doesn't recognize it. I tried editing it using Mp3tag, and now LRCGET can see all the files I want to search for lyrics. This issue also occurs when the file contains multiple composers.

ginjaninja1 commented 5 months ago

I just figured this out. When a file contains multiple genres, for example: Rock\Metal, LRCGET doesn't recognize it. I tried editing it using Mp3tag, and now LRCGET can see all the files I want to search for lyrics. This issue also occurs when the file contains multiple composers.

perhaps its a specific separator type or TAG format becuase i cant reproduce your findings.. image

zAgny commented 5 months ago

I just figured this out. When a file contains multiple genres, for example: Rock\Metal, LRCGET doesn't recognize it. I tried editing it using Mp3tag, and now LRCGET can see all the files I want to search for lyrics. This issue also occurs when the file contains multiple composers.

perhaps its a specific separator type or TAG format becuase i cant reproduce your findings.. image

I can't reproduce the issue anymore either. When I first encountered the missing files, I compared them with the ones that were showing up fine and realized the difference: the missing files had genres and composers with "\" separators. The files that LRCGET displayed didn't have these separators. So, I deleted the separators and refreshed the list, and the missing files appeared. Now, I can't replicate the issue, and all my files, even those with "\" separators, are showing up.

ginjaninja1 commented 5 months ago

FWIW I find INVOLVEDPEOPLE result is 100% reproducible... Add the TAG Refresh the library Track Disappears Remove the TAG Refresh the library Track Appears Add the TAG Refresh the library Track Disappears etc

my conclusion...at least for the INVOLVEDPEOPLE tag..nothing is sticky and confusing the test result..."refresh the library" seems to do what it says and [i'm assuming] wipes and starts again. (so difficult to make sense of your experience.?.you are saving your changes in mp3tag :-)?)

FWIW i have quite alot of multi value tags (not so much genres) and LRCGET doesnt seem to have a general problem with multi value tags but it definitely has a problem at least with presence of TAG INVOVLEDPEOPLE (seemingly regardless of whether the tag has multiple values/separators).

tranxuanthang commented 5 months ago

@zAgny @ginjaninja1 Some of the problems might have already been fixed after upgrading lofty in https://github.com/tranxuanthang/lrcget/commit/dcec6f566096fb0ffbb71e85da882096d1d50415. Maybe that's why you can't reproduce this anymore.

ginjaninja1 commented 5 months ago

I take back what i said about multivalue tags....

I can reproduce your genre issue by using genre value of "Rock\\Metal" in mp3tag.

IIRC \\ means something very specific to the way mp3tag writes the tag..i think it means "insert null". but in any any case its how mp3tag appreciates a true multivalue tag as opposed to a string with separator.

multivalue - LRCGET can not read/show image

string with separator - LRCGET can read/show image

any 'true' multivalue tag i create in mp3tag seems to stop LRCGET..im going to get out the hex edit to find out what mp3tag is actually writing to the file

edit it is a null spearator that is one of the things breaking LRCGET i think https://community.mp3tag.de/t/using-as-null-separator-for-multiple-values/52669 https://community.metabrainz.org/t/solved-how-to-set-the-null-aka-double-backslash-separator-within-multi-value-tags/586496

FawazCodes commented 3 months ago

I figured out why LRCGET isn't showing all files. The trick is to make sure every file has an album name in its metadata. Once I added album names to the songs that were missing them, LRCGET started recognizing and displaying all the tracks correctly.