search

trapd00r / LS_COLORS

A collection of LS_COLORS definitions; needs your contribution!
Other
2.11k stars 260 forks source link

Commit generated files to the repo & automate the process through actions when PRs are merged. #182

Closed ahmedelgabri closed 2 years ago

ahmedelgabri commented 2 years ago

@rpdelaney This should resolve these comments https://github.com/trapd00r/LS_COLORS/pull/136#issuecomment-1008016088 & https://github.com/trapd00r/LS_COLORS/pull/136#issuecomment-1017747753.

rpdelaney commented 2 years ago

Thank you very much for this!!

When I do make with no arguments, the files are deleted out of the repo. I think most users would expect to see the files rebuilt. Perhaps the generate target can be renamed to all?

cc @trapd00r : I just want to give you a heads up since this is a significant departure from how we've been distributing LS_COLORS in the past. But I do think it's a big improvement over the status quo.

ahmedelgabri commented 2 years ago

@rpdelaney update the PR & now generate is the default target.

rpdelaney commented 2 years ago

Awesome. Thanks again!

paulirish commented 2 years ago

Long-time user.. Dumb question... I never understood how the older source interacted with the dircolors command.. But can someone explain why dircolors isn't needed any longer? (Right now I'm seeing #158 and trying to figure out if things are broken…)

paulirish commented 2 years ago

But can someone explain why dircolors isn't needed any longer?

Derp. Okay I see that it's just done in the makefile and the post-dircolors file is now in the repo. 👍