LS_COLORS restructuring

trapd00r / LS_COLORS

A collection of LS_COLORS definitions; needs your contribution!

Other

2.11k stars 260 forks source link

LS_COLORS restructuring #191

Closed rpdelaney closed 2 years ago

rpdelaney commented 2 years ago

This change restructures the LS_COLORS file without making any changes to dircolors output, as I confirmed via the Makefile.

vim-specific folds and annotations are removed.
Sorting of the extensions is reworked a bit, although this still isn't as scientific as I would like. It's progress though.
Comments are moved inline and many new comments are added. These comments are formatted to prepare for parsing the LS_COLORS file out into style sheets to help enforce stylistic consistency.

rpdelaney commented 2 years ago

@trapd00r Let me know if you'd rather I just went ahead and made changes like this rather than tagging you.

trapd00r commented 2 years ago

@rpdelaney Looks really good, nice work! I seem to recall an issue somewhere that NORMAL or FILE had to be defined first, but I can't remember the details and I don't see any problems on my box. Or perhaps the issue was coming from that either of them wasn't defined at all...

Oh, and those pesky vim folds... nice to see them gone. :) Anyway, the testing I've done seems to work just fine, so again, nice work!

rpdelaney commented 2 years ago

I seem to recall an issue somewhere that NORMAL or FILE had to be defined first

Now that you mention it, I think I remember something about that too. I'll dig into that a bit more before merging.