search

trash-bin99 / pe

0 stars 0 forks source link

Irrelevant error message given when contact name is too long #4

Open trash-bin99 opened 2 years ago

trash-bin99 commented 2 years ago

image.png

Steps to reproduce: Type in the following command:

touch -n verylongnameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee -p 98765432 -e johnd@example.com -a John street, block123, #01-01

Expected: A proper error message explaining that the contact name is too long, and the constraint needed (over 50 characters)

Actual: An irrelevant error message stating that our friend's name is too long and we should unfriend them

This is clearly an attempt at humor by the devs, but it fails at its function as an error message to provide insight to a user as to why their command has failed.

nus-pe-bot commented 2 years ago

Team's Response

too long is an indication of why the command failed, so this serves as the insight that you are looking for. Furthermore, it was mentioned explicitly in the UG that the maximum length of the name is 70 characters.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

The entire purpose of a error message is to provide specific details on what the user has done wrong so they can remedy their mistakes, but instead the team uses it as a way to poke fun at the user. They should have specifically mentioned that the name should not have exceeded 70 characters, which would not take much effort at all. Furthermore, the user can not be expected to refer to the UG every time they encounter a cryptic error message to find out what the constraint for the input field is, when it could simply be included inside the error message which saves time and effort for the user. A more sensible error message would be:

Your contact's name can not be more than 70 characters!