trashbirdecology / bbsAssistant

An R package for downloading and handling data and information from the North American Breeding Bird Survey.
Creative Commons Zero v1.0 Universal
27 stars 13 forks source link

overwrite.bbs=TRUE doesn't appear to download the bbs data again #82

Closed chrischizinski closed 4 years ago

chrischizinski commented 4 years ago

Describe the bug It appears that using overwrite.bbs = TRUE does not allow `download_bbs() to download the data

suppressMessages(download_bbs(country.names="USA", data.dir = bbsDir, overwrite.bbs = TRUE, overwrite.routes = TRUE)) [1] "Data already exists. No data downloaded. To force installation, specify overwrite.bbs=TRUE, or delete local files." [1] "Data already exists. No data downloaded. To force installation, specify overwrite.bbs=TRUE, or delete local files."

sessionInfo() R version 3.6.1 (2019-07-05) Platform: x86_64-apple-darwin15.6.0 (64-bit) Running under: macOS Mojave 10.14.6

Matrix products: default BLAS: /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib LAPACK: /Library/Frameworks/R.framework/Versions/3.6/Resources/lib/libRlapack.dylib

locale: [1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] bbsAssistant_1.0.0

loaded via a namespace (and not attached): [1] Rcpp_1.0.3 pillar_1.4.2 compiler_3.6.1 prettyunits_1.0.2 remotes_2.1.0 tools_3.6.1 testthat_2.3.0 digest_0.6.23 pkgbuild_1.0.6
[10] pkgload_1.0.2 tibble_2.1.3 memoise_1.1.0 evaluate_0.14 pkgconfig_2.0.3 rlang_0.4.2 cli_1.1.0 rstudioapi_0.10 curl_4.2
[19] yaml_2.2.0 xfun_0.11 withr_2.1.2 dplyr_0.8.3 knitr_1.26 desc_1.2.0 fs_1.3.1 devtools_2.2.1 tidyselect_0.2.5 [28] rprojroot_1.3-2 glue_1.3.1 here_0.1 R6_2.4.1 processx_3.4.1 rmarkdown_1.16 sessioninfo_1.1.1 purrr_0.3.3 callr_3.3.2
[37] magrittr_1.5 backports_1.1.5 ps_1.3.0 ellipsis_0.3.0 htmltools_0.4.0 usethis_1.5.1 assertthat_0.2.1 crayon_1.3.4

trashbirdecology commented 4 years ago

This was resolved by removing an else() statement which defined overwrite.bbs, when it should not have been defined.