search

traud / asterisk-opus

Asterisk 13 transcoding module: Opus
GNU General Public License v2.0
31 stars 21 forks source link

Should the readme now state 14? #2

Closed danjenkins closed 8 years ago

danjenkins commented 8 years ago

You merged in a change to make this work on 14 but the readme doesn't tell you about it and the branch it was merged into was 13.7 ? Should all this be tidied up?

traud commented 8 years ago

Yes, an updated Read Me is in the works. By the way, Pull Requests are welcome because they show not just the change but what you are expecting.

When it comes to the branch name, this is a bit more complicated: Here in this repository, the branch name reflects the base version. Or stated differently: The code requires at least Asterisk 13.7 and is compatible up to the latest versions (currently: Asterisk 13.12 and 14.1). Because the base version did not change (the changes were backward compatible), no new branch is required.

Does that resolve the issue?

danjenkins commented 8 years ago

Sure - and I would have done a PR but wanted some guidance on those issues before I did it :)