trautonen / coveralls-maven-plugin

Maven plugin for submitting Java code coverage reports to Coveralls web service.
MIT License
312 stars 123 forks source link

eta on java 11 support? #137

Open jgangemi opened 4 years ago

jgangemi commented 4 years ago

is there an eta on when a release will be cut that supports this? thanks!

frimtec commented 4 years ago

See my pull request #138 to fix the issue.

abelsromero commented 4 years ago

Thanks for the fix @frimtec. For anyone waiting for it, know as a workarround you can add the dependencies in your own build

            <plugin>
                <groupId>org.eluder.coveralls</groupId>
                <artifactId>coveralls-maven-plugin</artifactId>
                <version>${maven.coveralls.plugin.version}</version>
                <dependencies>
                    <dependency>
                        <groupId>jakarta.xml.bind</groupId>
                        <artifactId>jakarta.xml.bind-api</artifactId>
                        <version>2.3.2</version>
                    </dependency>
                    <dependency>
                        <groupId>org.glassfish.jaxb</groupId>
                        <artifactId>jaxb-runtime</artifactId>
                        <version>2.3.2</version>
                    </dependency>
                </dependencies>
            </plugin>
portlek commented 3 years ago

It seems the latest solution doesn't work at all. I found a new solution for that here;

<plugin>
  <groupId>org.jacoco</groupId>
  <artifactId>jacoco-maven-plugin</artifactId>
  <version>0.8.6</version>
  <executions>
    <execution>
      <id>prepare-agent</id>
      <goals>
        <goal>prepare-agent</goal>
      </goals>
    </execution>
  </executions>
</plugin>
<plugin>
  <groupId>org.eluder.coveralls</groupId>
  <artifactId>coveralls-maven-plugin</artifactId>
  <version>4.3.0</version>
  <configuration>
    <failOnServiceError>false</failOnServiceError>
  </configuration>
  <dependencies>
    <dependency>
      <groupId>javax.xml.bind</groupId>
      <artifactId>jaxb-api</artifactId>
      <version>2.3.1</version>
    </dependency>
  </dependencies>
</plugin>

It worked on me.

ebourg commented 1 year ago

I confirm adding the jaxb-api dependency works with Java 11 and 17

PabloThiele commented 1 year ago

I confirm adding the jaxb-api dependency works with Java 11 and 17

@ebourg Could you please confirm and make a PR with that?