search

trautonen / coveralls-maven-plugin

Maven plugin for submitting Java code coverage reports to Coveralls web service.
MIT License
311 stars 124 forks source link

No source in memory #79

Closed psiniemi closed 9 years ago

psiniemi commented 9 years ago

The source of the file is not actually needed in memory except for calculating lines and writing the report. This pull request always reads the source from the resolved file as needed.

psiniemi commented 9 years ago

One important note about this PR: it upgrades the source to Java 7 (EOL in April 2015) - Java 6 EOL was in Feb 2013 and it's dangerously buggy. IMHO it's time to gently nudge build servers off of Java 6.

trautonen commented 9 years ago

Crawled the Coveralls docs again and actually found something interesting. They have dropped the source from submissions and now it can be replaced with source_digest hash.

I think we could replace the source content with MD5 or murmur hash. That would also solve the problem of keeping the source contents in memory.

I have been thinking also dropping Java 6 support. And I guess now it's the time. I will release 3.2.0 with minor improvements before this. Then I can bump up to 4.0.0 with Java 7 requirement and also improve handling of the build timestamps.

trautonen commented 9 years ago

In #81 changed to source_digest so no additional tweaks required.