search

trautonen / coveralls-maven-plugin

Maven plugin for submitting Java code coverage reports to Coveralls web service.
MIT License
312 stars 123 forks source link

Request for HTTP proxy support #92

Closed bindul closed 8 years ago

bindul commented 8 years ago

The plug-in, seems to be using HttpClient without any support for HTTP(s) proxy servers. (see CoverallsClient).

While I completely understand most public CI servers do not need this feature, it is valuable when working behind firewalls and debugging configuration / setup.

Support for proxy settings from maven settings.xml would be extremely useful; if not, at least support for command line (http_proxy=...) or configuration parameters in the plugin (with user overrides) would work.

trautonen commented 8 years ago

@bindul can you test with 4.2.0-SNAPSHOT version from https://oss.sonatype.org/? There is now support for Maven settings.xml based proxy.

bindul commented 8 years ago

@trautonen Thank you for a quick fix. Verified the fix works; I can upload coverage information from behind a proxy using the 4.2.0-SNAPSHOT version of the plugin.

trautonen commented 8 years ago

Ok, great to hear. I will do one small feature before releasing 4.2.0.