ommit out of bounds covered lines

trautonen / coveralls-maven-plugin

Maven plugin for submitting Java code coverage reports to Coveralls web service.

MIT License

311 stars 124 forks source link

ommit out of bounds covered lines #97

Closed witokondoria closed 8 years ago

witokondoria commented 8 years ago

As a mixure between scala, traits and jacoco can end in coverage info on lines greater than the source file, it would be nice to not include that coverage, lust log the error and keep on going.

trautonen commented 8 years ago

@witokondoria I cannot accept this pull request because it creates faulty behavior as discussed in #98. Instead, you should use scoverage instead of trying to parse invalid line numbers.

witokondoria commented 8 years ago

Well, its narrowing the scope of the plugin. Just dont announce compatibility with JaCoCo, but with JaCoCo on non-generated-bytecode environments.

The idea after this PR was to add some flexibility to this plugin (instead of breaking its usage)