travcunn / django-zip-stream

Django extension to assemble ZIP archives dynamically using Nginx.
MIT License
13 stars 2 forks source link

Fix fields order #15

Closed okalachev closed 7 years ago

okalachev commented 7 years ago

Hey!

According to official documentation of nginx's mod_zip, the correct order of fields in response body is CRC-32 size location name; but not CRC-32 name location size, as it has been in the package.

This fixes it.

codecov-io commented 7 years ago

Codecov Report

Merging #15 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          11     11           
  Branches        1      1           
=====================================
  Hits           11     11
Impacted Files Coverage Δ
django_zip_stream/responses.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bef5903...51159ea. Read the comment docs.

travcunn commented 7 years ago

@okalachev Hey, thanks for fixing this!