search

travelbank / ember-flickity

ember addon for Flickity
MIT License
4 stars 6 forks source link

move from bower to npm for flickity dep #9

Closed briangonzalez closed 7 years ago

dylanfoster commented 7 years ago

Looks like the tests are failing on node v4

briangonzalez commented 7 years ago

@dylanfoster The current active node LTS is 6.0 – mind if I remove node 4?

dylanfoster commented 7 years ago

👍 might as well bump the node engine in package.json as well (probably 6.11 is best)

briangonzalez commented 7 years ago

@dylanfoster do you know where ember-try's node versions are declared?

dylanfoster commented 7 years ago

https://github.com/travelbank/ember-flickity/blob/develop/.travis.yml#L3-L6

briangonzalez commented 7 years ago

@dylanfoster done :)

briangonzalez commented 7 years ago

@dylanfoster we're looking good now :)