search

travelist / angular2-fontawesome

Angular5 Components and Directives for Fontawesome
MIT License
87 stars 20 forks source link

Angular 4 issue #30

Open brasycad opened 7 years ago

siovene commented 7 years ago

Ok, @brasycad didn't bother with a description, but I think he means that this library should be updated to support Angular 4. At the moment using it results in peer dependency warnings, even tho the library actually works. Perhaps a simple update to package.json?

brasycad commented 7 years ago

Sorry for no description. You need to fix a small compilation error with angular 4 for production:

ERROR in /Users/josemanuelvillaralarcon/GitHub/brasycad-imoveis/src/$$_gendir/node_modules/angular2-fontawesome/src/fa.component.ngfactory.ts (1,1): Property 'classList' is private and only accessible within class 'FaComponent'. Thank you. I hope it help

AdrianSima commented 7 years ago

What @siovene says was my initial guess too and temporarily fixed it by adding || >=4.0.0 to the dev and peer dependencies in package.json like this: `"devDependencies": { "@angular/common": "^2.1.0 || >=4.0.0", "@angular/compiler": "^2.1.0 || >=4.0.0", "@angular/compiler-cli": "^2.1.0 || >=4.0.0", "@angular/core": "^2.1.0 || >=4.0.0",

... "peerDependencies": { "@angular/common": "^2.0.0 || >=4.0.0", "@angular/core": "^2.0.0 || >=4.0.0" }`

I think the error @brasycad wishes to report is linked to #28

I apologize if I am making a mess here, but I don't really know what I am doing.

brasycad commented 7 years ago

Hi, @AdrianaSima. I tried with new package.json, but still give same compilation error. Any suggestion