Wrong argument order to gen_tcp:controlling_process/2

travelping / flower

FlowER - a Erlang OpenFlow development platform

http://travelping.github.com/flower

MIT License

61 stars 14 forks source link

Wrong argument order to gen_tcp:controlling_process/2 #2

Closed etnt closed 11 years ago

etnt commented 11 years ago

The argument order is wrong in the call made to gen_tcp:controlling_process/2 from flower_tcp_transport:handle_accept/2.

tolbrino commented 11 years ago

Thanks, well spotted. But I'd prefer a match with ok since that would have shown the error before already.

yamt commented 11 years ago

i investigated and fixed the same bug today. pulling fixes sooner would be better!

RoadRunnr commented 11 years ago

merge the tcp:controlling_process/2 changes

i would also take the other changes, except for the formatting of the -export([]) statements, the comma (,) should not be the first character on a line

etnt commented 11 years ago

Ok, I've adjusted the export now + added som more fixes. I've rebased my master so it should result in an easy fast-forward merge.

RoadRunnr commented 11 years ago

all taken, also cleaned buffer_id usage and exported features_all/0