search

travelping / flower

FlowER - a Erlang OpenFlow development platform
http://travelping.github.com/flower
MIT License
61 stars 14 forks source link

More fixes, e.g making SSL transport possible. #5

Open etnt opened 11 years ago

etnt commented 11 years ago

Before, tcp was hardocded in flower_datapath.erl.

tolbrino commented 11 years ago

Hi Tobbe,

We think the setopts calls were misplaced in the flower_datapath module from the start and should be handled by the TransportMod in use (e.g. flower_tcp_transport). Thus, could you create a callback module for SSL and adjust the setopts calls accordingly? Also if you feel adventurous, I wouldn't mind having a test covering the tcp and ssl callback usage.

Let me know if you'll have a stab at this, otherwise we will. Your other changes look fine to me.

Cheers Tino

etnt commented 11 years ago

Hm...we have done the transition to 80 columns already. I've pushed the code to my fork in a branch named: 80-columns So before any new changes are made you probably need to decide if you want to merge in the 80-columns branch and then we can go on from there.

The code in the branch includes all the fixes above, including the "Fixing wrong wildcard...." commit.

Cheers, Tobbe

tolbrino commented 11 years ago

Yes, that is a big change. I'll have a look and update you soon on this.

etnt commented 11 years ago

Hi again, how's it going with this 80 columns thing? It's unfortunate if we should get diverging code bases here, don't you think?

Cheers, Tobbe