Closed etnt closed 11 years ago
Hi Tobbe,
Feel free to submit a patch. It would be welcome. Please make sure you don't include any structural or functional changes though, so we can easily review and merge it.
Cheers Tino
Great! Would be good if you could take a look at my latest pull-request before I submit the 80-cols patch.
Cheers, Tobbe
Hi,
----- Original Message -----
Great! Would be good if you could take a look at my latest pull-request before I submit the 80-cols patch.
Will do, hopefully I have some time soon.
Please don't be to aggressive with the 80-cols change. The days of 80-cols terminals are long gone and too aggressive wrapping makes the code unreadable. Personally, I consider everything up to 120-cols as ok.
Regards Andreas
Cheers, Tobbe
Reply to this email directly or view it on GitHub: https://github.com/travelping/flower/issues/6#issuecomment-14613368
Dipl. Inform. Andreas Schultz
email: as@travelping.com phone: +49-391-819099-224 mobil: +49-170-2226073
------------------ managed broadband access ------------------
Travelping GmbH phone: +49-391-8190990 Roentgenstr. 13 fax: +49-391-819099299 D-39108 Magdeburg email: info@travelping.com GERMANY web: http://www.travelping.com
Company Registration: HRB21276 Handelsregistergericht Chemnitz
Also the days of card punches are even longer gone.. Although I suspect i'm one of the few who actually used punch card decks :-)
From: Andreas Schultz [mailto:notifications@github.com] Sent: Friday, March 08, 2013 10:48 AM To: travelping/flower Subject: Re: [flower] 80 columns formatting? (#6)
Hi,
----- Original Message -----
Great! Would be good if you could take a look at my latest pull-request before I submit the 80-cols patch.
Will do, hopefully I have some time soon.
Please don't be to aggressive with the 80-cols change. The days of 80-cols terminals are long gone and too aggressive wrapping makes the code unreadable. Personally, I consider everything up to 120-cols as ok.
Regards Andreas
Cheers, Tobbe
Reply to this email directly or view it on GitHub: https://github.com/travelping/flower/issues/6#issuecomment-14613368
Dipl. Inform. Andreas Schultz
email: as@travelping.com phone: +49-391-819099-224 mobil: +49-170-2226073
------------------ managed broadband access ------------------
Travelping GmbH phone: +49-391-8190990 Roentgenstr. 13 fax: +49-391-819099299 D-39108 Magdeburg email: info@travelping.com GERMANY web: http://www.travelping.com
Company Registration: HRB21276 Handelsregistergericht Chemnitz
Reply to this email directly or view https://github.com/travelping/flower/issues/6#issuecomment-14613667 it on GitHub. https://github.com/notifications/beacon/QobvFMvXK2rBVld6T-_9VIUU9D0IWCkBpva vGXgjPsVFIvzAqrHkAaIUAfEWYY9C.gif
The main reason for the 80-column rule is that we want to conform to the OTP coding standard.
Another (more personal :-) reasons are:
Btw, I've also used punch cards (must have been around 1985... :-)
Cheers, Tobbe
Hi,
I was just wondering if it would be ok to format all of the flower code to adhere to the "golden" 80-columns rule?
It would make it much easier for us to provide future patches. I could do the formatting if you'd agree to it.
Cheers, Tobbe