search

travelping / hello

Erlang RPC server framework
MIT License
31 stars 20 forks source link

Hostname and IP address mapping #95

Open GalaxyGorilla opened 8 years ago

GalaxyGorilla commented 8 years ago

Currently hostnames are not mapped to IPs using e.g. /etc/hosts. This would be an easy change in the client transport protocol modules.

Just from a quick look I would say that inet offers the functionality which is needed here.

mgumz commented 8 years ago

and this here is the place where it should happen: https://github.com/travelping/hello/blob/master/src/transports/hello_zmq_client.erl#L98-L99

and ... this here looks usable http://erlang.org/doc/man/inet.html#getaddr-2

00dingens commented 8 years ago

This is fixed in #96

00dingens commented 8 years ago

TODO: Hostnames are not resolved at hello_http_client in http_connect_url/1. (see Code.) The IPv4/v6 information might be in authority.