travelping / upg-vpp

User Plane Gateway (UPG) based on VPP
Apache License 2.0
148 stars 51 forks source link

check user_handlers on timer stop #339

Closed RoadRunnr closed 1 year ago

ivan4th commented 1 year ago

Looks good, but a couple of points:

RoadRunnr commented 1 year ago

Looks good, but a couple of points:

  • Perhaps this PR should include a revert of 40613cd (otherwise there's a conflict)
  • It would be easier to scan the logs for timer errors if the messages related to timer problems have a common prefix such as timer error:

both done

ivan4th commented 1 year ago

@RoadRunnr do we still need this PR after we merged #341?

korroot commented 1 year ago

Closing as all relevant changes are included in #341