search

travelping / upg-vpp

User Plane Gateway (UPG) based on VPP
Apache License 2.0
148 stars 51 forks source link

[CENNSO-1030] Revert the new timer wheel implementation for now #344

Closed ivan4th closed 1 year ago

ivan4th commented 1 year ago

It turned out to have a substantial memory leak, possibly with some timers not being cleaned up during session updates. Reverting for now to have more time for debugging and validation

RoadRunnr commented 1 year ago

I've state many times that the changed timer wheel had a good chance of having memory leaks. So, this is nothing new or surprising. Instead of reverting the changes, finding and fixing the missing timer cleanups would be much more helpful.

ivan4th commented 1 year ago

@RoadRunnr That's the plan actually, to have the changes merged back as soon as we fix the issues. The revert is needed as a temporary measure due to release timings