travelping / upg-vpp

User Plane Gateway (UPG) based on VPP
Apache License 2.0
148 stars 51 forks source link

[CENNSO-767] feat: added proper errors to packets dropped in upf-ip[46]-forward node #351

Closed demo-exe closed 1 year ago

ivan4th commented 1 year ago

I think this is ok, except for one minor detail: I think it would make a little bit more sense to return true from process_urrs() and process_qers() when the packet is NOT to be dropped (b.c. "processed successfully", roughly speaking, it's better when the packets don't have to be dropped ;)