UPG allows duplicate IDs in Session Creation / Modification requests

travelping / upg-vpp

User Plane Gateway (UPG) based on VPP

Apache License 2.0

148 stars 51 forks source link

UPG allows duplicate IDs in Session Creation / Modification requests #92

Open ivan4th opened 3 years ago

ivan4th commented 3 years ago

This was verified for Session Creation Requests with duplicate URR Ids, but likely applies to other IEs and to Session Modification Requests, too

RoadRunnr commented 3 years ago

Duplicate PDR/FAR/URR Ids in PFCP Session Establishment Request are IMHO not permitted. And I'm quite sure that erGW is not generating such requests.

How did you come by those requests?

ivan4th commented 3 years ago

I made a mistake in an E2E test case and noticed that issue (request succeeded despite duplicate IDs). As indeed ergw doesn't generate such requests, the problem is not critical but nevertheless worth fixing at some point. Such requests need to be rejected.