search

traversaro / drake-lite-cmake

Reduced (lite) unofficial version of drake (https://drake.mit.edu/) that can be built with CMake.
11 stars 0 forks source link

GitHub Actions: Explicitly disable symlinks on Windows and bump spdlog to v1.7.0 #18

Closed traversaro closed 4 years ago

traversaro commented 4 years ago

Workaround for https://github.com/traversaro/drake-lite-cmake/issues/17 .

traversaro commented 4 years ago

Now there is a new error in spdlog compilation:

 D:\a\drake-lite-cmake\drake-lite-cmake\spdlog\include\spdlog/details/fmt_helper.h(37,43): error C3083: 'internal': the symbol to the left of a '::' must be a type [D:\a\drake-lite-cmake\drake-lite-cmake\spdlog\build\spdlog.vcxproj]
D:\a\drake-lite-cmake\drake-lite-cmake\spdlog\include\spdlog/details/fmt_helper.h(37,53): error C2039: 'count_digits': is not a member of 'fmt' [D:\a\drake-lite-cmake\drake-lite-cmake\spdlog\build\spdlog.vcxproj]

Probably it is the effect of some update of MSVC or similar.

traversaro commented 4 years ago

Now there is a new error in spdlog compilation:

 D:\a\drake-lite-cmake\drake-lite-cmake\spdlog\include\spdlog/details/fmt_helper.h(37,43): error C3083: 'internal': the symbol to the left of a '::' must be a type [D:\a\drake-lite-cmake\drake-lite-cmake\spdlog\build\spdlog.vcxproj]
D:\a\drake-lite-cmake\drake-lite-cmake\spdlog\include\spdlog/details/fmt_helper.h(37,53): error C2039: 'count_digits': is not a member of 'fmt' [D:\a\drake-lite-cmake\drake-lite-cmake\spdlog\build\spdlog.vcxproj]

Probably it is the effect of some update of MSVC or similar.

I think the problem was due to the fact that we get fmt from the latest vcpkg (for testing eventual regression), while spdlog was obtained from the v1.6.0 . As discussed in https://github.com/microsoft/vcpkg/pull/12312, this creates problems. Bumping spdlog to v1.7.0 should solve the problem.