traversc / qs

Quick serialization of R objects
397 stars 19 forks source link

Saving ggplot object results in indefinitely growing file #89

Closed sakrejda-umich closed 5 months ago

sakrejda-umich commented 8 months ago

On qs version 0.25.7, the following code causes the save file to grow indefinitely. Not clear from here why.

libary(ggplot2)
qs::qsave(x = ggplot(), file = 'test.qs')

I'm happy to help reproduce if the above doesn't do it.

traversc commented 8 months ago

Hi, I will need some help reproducing. Here's my output:

library(ggplot2)
qs::qsave(x = ggplot(), file = '/tmp/test.qs')
sessionInfo()
file.info("/tmp/test.qs")

R version 4.3.2 (2023-10-31)
Platform: x86_64-conda-linux-gnu (64-bit)
Running under: CentOS Linux 7 (Core)

Matrix products: default
BLAS/LAPACK: ...

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C              
 [3] LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8    
 [5] LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8   
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C            
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C       

time zone: Etc/UTC
tzcode source: system (glibc)

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] ggplot2_3.4.4

loaded via a namespace (and not attached):
 [1] utf8_1.2.4          R6_2.5.1            tidyselect_1.2.0   
 [4] magrittr_2.0.3      gtable_0.3.4        glue_1.7.0         
 [7] RApiSerialize_0.1.2 tibble_3.2.1        pkgconfig_2.0.3    
[10] RcppParallel_5.1.7  generics_0.1.3      dplyr_1.1.4        
[13] lifecycle_1.0.4     cli_3.6.2           fansi_1.0.6        
[16] scales_1.3.0        grid_4.3.2          vctrs_0.6.5        
[19] withr_2.5.2         compiler_4.3.2      stringfish_0.16.0  
[22] munsell_0.5.0       pillar_1.9.0        Rcpp_1.0.12        
[25] colorspace_2.1-0    rlang_1.1.3         qs_0.25.7   
              size isdir mode               mtime               ctime
/tmp/test.qs 16588 FALSE  644 2024-01-10 18:53:32 2024-01-10 18:53:32
...
sakrejda commented 7 months ago

Ok, I have a couple of systems I can try it on so I'll see if it's reproducible on my end before I update

traversc commented 5 months ago

Closing for now, please feel free to reopen