search

travijuu / NumberPicker

A simple customizable NumberPicker plugin for Android
MIT License
101 stars 27 forks source link

minSdkVersion 16 #10

Open simonpoole opened 6 years ago

simonpoole commented 6 years ago

Hi I'm maintaining an app that supports back to Android SDK 9 (we actually just dropped 8 for our current release a couple of months back). I was looking for a compact non-fancy number picker that we could use. However you've got minSdkVersion set to 16 even though it doesn't seem necessary from a short glance at the code (I actually recompiled with minSdkVersion 9 and tested on a real 2.3 device without problems).

Any chance you would consider lowering minSdkVersion ? I'm trying to avoid forking/rolling my own.

Thanks

travijuu commented 6 years ago

Hi @simonpoole I'm going to accept it if you open a pr about it. also I saw new features in your fork, It'd be great to merge them with this project

simonpoole commented 6 years ago

hi @travijuu I'm not particularly in love with maintaining my own fork (just needed to have a version somewhere that people could use for builds), no guarantees before Christmas but I'll try :-)