Add GET /events for fetching all known lifecycle events

travis-ci / cyclist

AWS ASG lifecycle thing :tada: :bicyclist:

MIT License

8 stars 2 forks source link

Add GET /events for fetching all known lifecycle events #24

Closed meatballhat closed 7 years ago

meatballhat commented 7 years ago

meant for consumption by humans, scripts, automation. I found myself wanting this, and was messing with redis directly instead, so here it is.

codecov-io commented 7 years ago

Current coverage is 66.71% (diff: 25.33%)

Merging #24 into master will decrease coverage by 4.86%

@@             master        #24   diff @@
==========================================
  Files            11         11          
  Lines           679        748    +69   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            486        499    +13   
- Misses          155        210    +55   
- Partials         38         39     +1

Powered by Codecov. Last update 5aa475d...8c9a4e4

solarce commented 7 years ago

Could you please provide a brief summary of how you figured out the solution to your fight with SCAN in this PR? Thanks

meatballhat commented 7 years ago

@solarce Sorry, I didn't see this comment until I triggered the merge. I should have refreshed first. Is my follow-up comment to @igorwwwwwwwwwwwwwwwwwwww's original feedback sufficient?

solarce commented 7 years ago

yes. i think so. 👌

igorwwwwwwwwwwwwwwwwwwww commented 7 years ago

Thanks for the SCAN fix 👍