search

travis-ci / docs-travis-ci-com

The Travis CI Documentation
http://docs.travis-ci.com
587 stars 3.21k forks source link

Elastic beanstalk deployments docs should explain why an s3 bucket needs to be specified #2005

Closed daniel-craig closed 6 years ago

daniel-craig commented 6 years ago

There is no explanation given for the rationale behind requiring the name of an s3 bucket when deploying to Beanstalk. This is confusing to new users. See https://docs.travis-ci.com/user/deployment/elasticbeanstalk/

iriberri commented 6 years ago

Hi @daniel-craig - thanks a lot for opening this issue and bringing this to our attention.

I've been investigating about EBS and I see that the applications deployed via this provider require a source bundle that can be a bucket in "Amazon S3, a commit in AWS CodeCommit, or the output of an AWS CodeBuild build (https://docs.aws.amazon.com/elasticbeanstalk/latest/api/API_CreateApplicationVersion.html).

After having read this, do you think the following proposal will be helpful?:

bucket_name: Bucket name to upload the code of your app to. Elastic Beanstalk will create an application version from the source bundle in this Amazon S3 bucket.

daniel-craig commented 6 years ago

Elastic Beanstalk will create an application version from the source bundle in this Amazon S3 bucket.

This is just what I was looking for, and I think it could improved a little if it stated that the application version that Beanstalk creates is the version that gets deployed i.e.

Elastic Beanstalk will create and deploy an application version from the source bundle in this Amazon S3 bucket.

daniel-craig commented 6 years ago

I created a PR for your convenience: https://github.com/travis-ci/docs-travis-ci-com/pull/2007

iriberri commented 6 years ago

Closing as per https://github.com/travis-ci/docs-travis-ci-com/pull/2007. Thanks again!!