search

travis-ci / dpl

Dpl (dee-pee-ell) is a deploy tool made for continuous deployment.
MIT License
1.29k stars 367 forks source link

GitHub Pages fails if nothing to commit again #1216

Open djhoese opened 3 years ago

djhoese commented 3 years ago

See #1095 for the original issue and #1097 for the original fix. It seems this is an issue again in dpl2. I don't know ruby so I had trouble figuring out what was going on in https://github.com/travis-ci/dpl/blob/master/lib/dpl/providers/pages/git.rb, but my deployments are failing when there is nothing to commit.

Cloning the branch master from the remote repo
Copying /home/travis/build/vispy/vispy/doc/_build/html contents to /tmp/d20200922-17894-1tqiu6d
$ rsync -rl --exclude .git --delete "/home/travis/build/vispy/vispy/doc/_build/html/" .
Preparing to deploy master branch to gh-pages
$ echo "vispy.org" > CNAME
$ git add -A .
$ git commit -q -m "Deploy vispy.org website for SHA:81e248df5d0cb492e8c8fe15052dfc469898b4d2 (Tag: )"
On branch master
Your branch is up to date with 'origin/master'.
nothing to commit, working tree clean

Failed
failed to deploy

https://travis-ci.com/github/vispy/vispy/jobs/388864952

Am I doing something wrong?

andrewdavidmackenzie commented 3 years ago

Close as a duplicate of https://github.com/travis-ci/dpl/issues/1095 ??

djhoese commented 3 years ago

Maybe, but according to that issue it was fixed in dpl version 1, but my error is still occurring in dpl version 2. It is possible that the fix never got ported or that the fix no longer works, but I was still seeing this issue a year after #1097 was merged (I think). If it wasn't merged/ported to dpl2 or is not currently working still then this is not a pure duplicate.

andrewdavidmackenzie commented 3 years ago

Agreed the issue is not fixed (fails for me), but better to have only one issue for that, no?

djhoese commented 3 years ago

Sure but then that issue needs to be reopened. That issue was also for dpl v1 so maybe a second issue is OK? Since the issue was fixed and is now not fixed I assume it is a different cause. I guess it is maintainer preference on how this is treated. :shrug:

andrewdavidmackenzie commented 3 years ago

OK, makes sense. I'll follow both. Is there a way to select the version of deploy do you know?

djhoese commented 3 years ago

Nope, sorry. Only this: https://github.com/travis-ci/dpl/issues/1095#issuecomment-530448622

andrewdavidmackenzie commented 3 years ago

Yeh, I tried that - and didn't see any difference in behaviour...

stale[bot] commented 2 years ago

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues